- 🇳🇿New Zealand danielveza Brisbane, AU
Same issue still exists on 10.1.x, the patch will just need to be rerolled and tested against 10.1 to make sure it still passes tests.
I think
\Drupal\node\Form\NodePreviewForm
can be replaced with NodePreviewForm::class, but I'm unsure if thats out of scope for this. - 🇵🇭Philippines leolandotan
I have rerolled the patch for 10.1.x but didn't include the replacement of
\Drupal\node\Form\NodePreviewForm
withNodePreviewForm::class
yet. I also didn't remove the "Needs reroll" tag since it would still need it for 9.5.x. I hope this is alright. - Status changed to Needs review
almost 2 years ago 10:01am 7 February 2023 The last submitted patch, 21: 2832074-21.patch, failed testing. View results →
- Assigned to sahil.goyal
- Status changed to Needs work
almost 2 years ago 1:26pm 8 February 2023 - Issue was unassigned.
- 🇮🇳India sahil.goyal
- Status changed to Needs review
almost 2 years ago 5:41am 9 February 2023 - Status changed to RTBC
almost 2 years ago 2:38pm 13 February 2023 - 🇮🇳India ameymudras
Tested on 9.5.x patch #24
1. The issue summary is clear and explains the problem
2. The code change is as expected and as described in the issue summary
3. Applied the patch and checked for the "back to content editing" link on the node preview, which is shown as expected
4. Additional tests are not required in this caseLooks RTBC to me.
- Status changed to Fixed
almost 2 years ago 2:24pm 15 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.