Optimize ContentEntityBase::getTranslatedField and do not store field values under the default and the asked langcode under $values

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Updated the IS remaining tasks field
Reading the comments, specifically #4, this seems like it could be a bug and that we will need a test case showing the issue.

Adding reroll for 10.1.x

The last submitted patch, 26: 2828133-26.patch, failed testing. View results →

I stumbled across this issue while trying to debug something (and I cannot find another related issue). I have no opinion on the original issue description here, but just want to drop a note.

This is some current behavior of a non-translatable field on a translated entity, for better or worse:

$entity = get_some_entity()
// $entity->defaultLangcode: 'en'
// $entity->activeLangcode : 'de'
$field_item_list = $entity->get(NON_TRANSLATABLE_FIELD);
$check_entity = $field_item_list->getEntity();
// $check_entity->defaultLangcode: 'en'
// $check_entity->activeLangcode : 'x-default'

getEntity() gets the untranslated entity. I do not know if this was intended, or if this is documented anywhere...

but from reading the patch, I believe that this will change to $check_entity->activeLangcode == 'de'.

Maybe that's a good thing. But I'm guessing it needs to be taken into account, and documented somewhere.

(And maybe there needs to be a test for this, going forward?...)