The interface \Drupal\Core\TypedData\DataDefinitionInterface is missing the setConstraints() method that is defined in the \Drupal\Core\TypedData\DataDefinition::setConstraints even with the {@inheritdoc} tag. The method is present in the \Drupal\Core\Field\FieldConfigInterface::setConstraints for example, and I think it should be moved to the DataDefinitionInterface instead.
Allowing modules to overwrite the constraints of TypedData with the setConstraints method (instead of adding a constraint through addConstraint) seems like a valid use case.
An example of this is in \Drupal\Core\Field\FieldConfigBase
/**
* {@inheritdoc}
*/
public function setPropertyConstraints($name, array $constraints) {
$item_constraints = $this->getItemDefinition()->getConstraints();
$item_constraints['ComplexData'][$name] = $constraints;
$this->getItemDefinition()->setConstraints($item_constraints);
return $this;
}
Add the setConstraints method to \Drupal\Core\TypedData\DataDefinitionInterface.
Add the setConstraints method to \Drupal\Core\TypedData\DataDefinitionInterface.
Remove the setConstraints method from \Drupal\Core\Field\FieldConfigInterface::setConstraints
None
\Drupal\Core\TypedData\DataDefinitionInterface
None
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Should we deprecate the function out of FieldConfigInterface vs removing it?