- π¨π¦Canada bgilhome Victoria
The entity definition update for the 'crop' entity type in focal_point_update_8005() isn't working, it gives an error
The "" entity type does not exist.
I've removed it from the update function. This means the Status report will show a
Mismatched entity and/or field definitions
error, that's a to-do to fix.Also for some reason I needed to add a
setName()
call to the addedfocal_point_area
base field infocal_point_entity_base_field_info_alter()
, to avoid anUndefined array index "field_name"
warning. - π¨π¦Canada bgilhome Victoria
Ignore the above, all the entity definition update base field definition update needed was a call to the
setTargetEntityTypeId
method and I added a call tosetProvider
for good measure.Updated patch and interdiff from #21 attached.
- π¨π¦Canada bgilhome Victoria
Added a check to ensure CSS width/height of the preview image is set, otherwise there'll be errors calculating relative coords of the focal area (divide by 0). Updated patch & interdiff attached.
Adding focal_point_area.js back to patch. In focal_point_area.js, replaced reference to jQuery once() with Drupal once().
- Status changed to Needs review
about 1 year ago 1:01pm 20 November 2023 - last update
about 1 year ago Patch Failed to Apply - πΊπΈUnited States DamienMcKenna NH, USA
Moving this to the 2.x branch, which is where new features are being added.
- π©πͺGermany Anybody Porta Westfalica
Wouldn't you just use https://www.drupal.org/project/image_widget_crop β then perhaps?
If yes, we could close this won't fix and link the module as alternative on the module page?