- πΊπΈUnited States dww
At the bare minimum, I'd be in favor of moving the contributors to a separate line after the issue nid and short 1-line summary.
E.g.:
commit d1faffc7256b348628ae667e1180ede541dce3ec Date: Mon Apr 17 23:07:14 2023 +0100 Issue #3340712: Add Single Directory Components as a new experimental module by e0ipso, alexpott, larowlan, dww, _pratik_, catch, penyaskito, mherchel, pdureau, jonathanshaw, mglaman, idiaz.roncero, geek-merlin, ctrlADel, mrweiner, bnjmnm, longwave, guschilds, cosmicdreams, dreamleaf, ckrina, GΓ‘bor Hojtsy, lauriii, unstatu, markconroy, nod_
We could potentially put each contributor on its own line, perhaps with additional stuff like organizations.
Maybe even a role they're being credited for (author, reviewer, tester, etc), although that could start to get cumbersome, and in some cases, it's a pretty blurry distinction. E.g. if someone comes in with a very detailed review, suggests new code blocks, etc, are they just a reviewer or are they also sort of an author now?
But to start, the main thing is making the git log scannable so you can actually see what a commit changed, not a wall of usernames before you can even find out what the commit was for. All sorts of Git tooling expects a 1-line summary for each commit.
Thanks,
-Derek - πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
If we change this, I'd like to have one contributor per line, and we can use "tagging", but as @dww mentioned that could be hard.
Github and Gitlab already supports this:
Approved-by: Jane Doe
Reviewed-by: John Doe
Co-Authored-by: James DoeAnd for crediting also organizations if needed, https://gitlab.com/gitlab-org/gitlab/-/issues/327138 is relevant.
- Status changed to Needs review
over 1 year ago 11:28pm 3 May 2023 - πΊπΈUnited States dww
x-posting from #2323715-84: [policy, no patch] Determine format for commit credit for individuals/organizations/customers β for more visibility:
My only suggestion to the template in the summary is that instead of using "Issue" all the time, why not add value to those bytes and use the 1-word version of the category? Like so:
Bug #3029061: New layouts are missing config schema ... Task #3027938: Abstract the contents of LayoutBuilderController into a render element ... Feature #3015886: Add an in-memory config storage ...
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
#22 I think that adds a lot of value.
- Status changed to RTBC
9 months ago 3:33am 28 February 2024 - π³πΏNew Zealand quietone
Everyone who has commented on this issue supports using multiple lines in the git commit message.
The details of that format are currently being discussed in π± [policy, no patch] Determine format for commit credit for individuals/organizations/customers Needs review
- Status changed to Fixed
8 months ago 9:18am 1 April 2024 - π¬π§United Kingdom catch
Yeah I think this is fine, let's continue in π± [policy, no patch] Determine format for commit credit for individuals/organizations/customers Needs review .
Automatically closed - issue fixed for 2 weeks with no activity.