Use FileCache for infoParserDynamic.php

Created on 14 September 2016, almost 9 years ago
Updated 12 August 2025, 3 days ago

Problem/Motivation

FileCache is used for the info extension, but not for the actual parsing of the .info files.

Whenever system_rebuild_module_data() is called, this needs to parse the Yaml information.

Proposed resolution

- Add FileCache

Remaining tasks

- Add patch

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component

base system

Created by

πŸ‡©πŸ‡ͺGermany Fabianx

Live updates comments and jobs are added and updated live.
  • Performance

    It affects performance. It is often combined with the Needs profiling tag.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Yes this would be great!

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Feel free to move back if you think still valid!

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Whoops forgot to change status.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    This needs tests and profiling, but I moved the patch into an MR to see if anything fails outright.

  • Merge request !12996FileCache info files β†’ (Open) created by nicxvan
  • Pipeline finished with Failed
    about 9 hours ago
    Total: 119s
    #573327
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Actually now that I've looked at this I'm not sure we need this.

    InfoParserDynamic is only used by two things:
    InfoParser which already uses filecache to cache the results.
    InstallCommand which is only used for command line installs.
    getProfiles is called more than once, but not sure file cache is worth it in that situation.

    system_rebuild_module_data has been gone since D9 too.

Production build 0.71.5 2024