[PP-1] Cleanup gd/Rotate::execute() arguments array overloading

Created on 7 September 2016, almost 9 years ago
Updated 11 August 2025, 19 days ago

Problem/Motivation

Follow-up to #2464023-34: Move GD-specific code from Rotate::validateArguments() to Rotate::execute() β†’

The arguments array doesn't need to be overloaded. Local variables can simply be used, since the arg changes are not passed on anywhere outside execute().

Proposed resolution

Something like reverse applying interdiff.2464023.32a.32b.txt β†’

Note git diff --color-words will be helpful for reviewers.

Remaining tasks

User interface changes

No.

API changes

No.

Data model changes

No.

πŸ“Œ Task
Status

Postponed

Version

11.0 πŸ”₯

Component

image system

Created by

πŸ‡ΊπŸ‡ΈUnited States yesct

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024