Better documentation on how to allow Socket Connections

Created on 25 August 2016, over 8 years ago
Updated 30 August 2024, 3 months ago

When setting up Redis with D8, i've tried to implement it with sockets. When checking the code it seems this is not implemented yet. Would it be possible to add this in a future release of this module?

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇬🇷Greece vensires

    Since we are updating the README file, it might good to write down somewhere that in PHP 8.1 and above, we get the following error when using the common setup of $settings['redis.connection']['port'] = NULL;:
    Deprecated function: Redis::connect(): Passing null to parameter #2 ($port) of type int is deprecated in Drupal\redis\Client\PhpRedis->getClient() (line 32 of /XXX/modules/contrib/redis/src/Client/PhpRedis.php).

    I checked how Matomo handled this and it seems that the suggested way is to use the following instead:

    $settings['redis.connection']['port'] = 0;
    
  • First commit to issue fork.
  • Assigned to Anybody
  • Status changed to Needs work 7 months ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Just ran into this case myself and the information in this issue was very helpful. So let's get this finished :)

    #15 is correct, I'll prepare a MR based on #13 and #15.

  • 🇩🇪Germany Anybody Porta Westfalica
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Here we go. Please review the MR.

    I decided against all the magic from #5 and #11 because I think both might be confusing or even unexpected. So I think we should just explicitly document this.

    Please review and let's get this fixed after 8 years! :D

  • Pipeline finished with Success
    7 months ago
    Total: 332s
    #148939
  • Status changed to RTBC 7 months ago
  • 🇬🇷Greece vensires

    I totally agree that we shouldn't go on with any changes in the code. Just document. And your MR succeeds in this.
    So, I set it as RTBC ;)

  • Pipeline finished with Success
    7 months ago
    Total: 256s
    #148958
  • Pipeline finished with Skipped
    3 months ago
    #256176
  • Status changed to Fixed 3 months ago
  • 🇨🇭Switzerland berdir Switzerland

    Merged. Just documenting sounds good to me.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024