- First commit to issue fork.
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Not currently mergeable. - @fjgarlin opened merge request.
- last update
8 months ago 2,161 pass - 🇪🇸Spain fjgarlin
A very similar fix was made as part of 🐛 SQLite testing in GitlabCI - apache2(98)Address already in use Needs review but it was taken out in favor of this existing issue.
Exceptions thrown in setUp and tearDown are now caught and therefore reported properly to the CI system. - Status changed to RTBC
7 months ago 8:29am 9 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Came here from 🐛 SQLite testing in GitlabCI - apache2(98)Address already in use Needs review after a review. I think we can RTBC this one here as well! I checked both the PIFT and the GitLab CI results and all seem fine.
Also wanted to say that #2 showed the issue in a very understandable way :)
- last update
7 months ago 2,161 pass - last update
7 months ago 2,161 pass - last update
7 months ago 2,161 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,161 pass, 3 fail - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
7 months ago 2,163 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,154 pass, 2 fail - last update
6 months ago 2,166 pass - last update
6 months ago 2,165 pass, 1 fail - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
6 months ago 2,166 pass - last update
5 months ago 2,149 pass, 3 fail - last update
5 months ago 2,166 pass - last update
5 months ago 2,166 pass - 🇸🇰Slovakia poker10
I have reviewed the MR and it looks good to me. Compared with the #2, the
$this->tearDown();
is also moved to the try-catch block, but I think this solution is better, because we probably want alsotearDown()
to run without any exceptions. If there are any problems, it would be better to stop the execution with the exception, instead of "seeing what will happen" next.Tests are also green. Adding a tag. Thanks all!
- Status changed to Fixed
15 days ago 3:36pm 31 May 2024