- Issue created by @poker10
- First commit to issue fork.
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @fjgarlin opened merge request.
- last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - Assigned to fjgarlin
- 🇪🇸Spain fjgarlin
After several attempts, it seems that the problem is permissions related. Running the site install as user "www-data" seems to fix the issue.
I'll continue working on it next week, clean up the MR and see if we can capture that exception early on. - last update
over 1 year ago 1,274 pass, 242 fail - last update
over 1 year ago 2,160 pass, 1 fail - last update
over 1 year ago 2,161 pass - Status changed to Needs review
over 1 year ago 11:44am 27 October 2023 - 🇪🇸Spain fjgarlin
This is now ready to review.
Changes:
- Run the drupal drush install as www-data user so permissions in folders are set right.
- Changed the sqlite image to the one that was created to run sqlite tests.
- Wrapped the setup method in the try catch to make sure that early errors are also reported as errors by run-tests.sh
Full pipeline running here: https://git.drupalcode.org/issue/drupal-3397117/-/pipelines/40161
And sqlite jobs can be seen running here: https://git.drupalcode.org/issue/drupal-3397117/-/jobs/236784 - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,115 pass, 1 fail - last update
over 1 year ago 2,157 pass - last update
over 1 year ago 2,122 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,160 pass, 1 fail - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,122 pass - last update
over 1 year ago 2,159 pass, 3 fail - last update
over 1 year ago 2,161 pass - 🇸🇰Slovakia poker10
Thanks for working on this!
I think the changes in
pipeline.yml
and.gitlab-ci.yml
looks good and are in line with the D10 code.The change in
drupal_web_test_case.php
is indeed a good catch, but I am not sure if we should fix that here, as it does not seems to be 100% related to the SQLite issue (AFAICS SQLite seems to run again also when this try-catch fix was not added). I found this issue now: #2763435: Exceptions during the setUp() or tearDown() method of a test are not handled → , so I think we should split the fix here to just include the fixes topipeline.yml
and.gitlab-ci.yml
and move the try-catch fix to the mentioned issue, so we do not get things mixed up. - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - last update
over 1 year ago 2,161 pass - 🇪🇸Spain fjgarlin
Thanks for the feedback. I took out the changes from
drupal_web_test_case.php
and moved them to #2763435: Exceptions during the setUp() or tearDown() method of a test are not handled → , where there is now an MR ready to review.The changes for this issue and this MR are ready too. Only
pipeline.yml
and.gitlab-ci.yml
are changed now and all GitLab CI tests run as expected now. - Issue was unassigned.
- Status changed to RTBC
about 1 year ago 8:17am 9 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
MR looks straight forward enough and the fact the tests have been run successfully and are all green makes me think we can RTBC this and merge it! 🙂
- last update
about 1 year ago 2,161 pass - Status changed to Fixed
about 1 year ago 10:46am 10 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.