Use the PHP_BINARY constant in addition to --php in run-tests.sh

Created on 15 June 2016, about 8 years ago
Updated 25 January 2023, over 1 year ago

Problem/Motivation

Currently you sometimes have to use --php=path-to-php in order to let run-tests.sh know where PHP is because the custom crafted code used to automatically detect the php runtime fails on some circumstances.

Plus, the current implementation fails when the PHP runtime definition includes arguments in itself.

Proposed resolution

Use Symfony's PhpExecutableFinder() to find out the current PHP runtime and do not escape the runtime itself when preparing the command.

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task
Status

Postponed: needs info

Version

10.1

Component
Simpletest 

Last updated 26 days ago

Created by

🇩🇪Germany dawehner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

    With simpletest being removed in D10 is this still relevant?
    If so please update IS with the rescope.

Production build 0.71.5 2024