calculateDependencies doesn't check $mode_entity if it is NULL

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Thank you for this patch but I think it is actually not necessary to throw an exception for this issue.

I think it is not relevant to fail in EntityDisplayBase::calculateDependencies() because it breaks the saving of a new display.

Here is an example:

function create_a_new_display_programatically() {
  $entity_type_id = 'block_content';
  $bundle_id = 'basic';
  $view_mode_id = 'teaser';
  $entity_display_repository = \Drupal::service('entity_display.repository');

  // This method tries to load the view mode and if not found, creates it but not saved yet.
  $display = $entity_display_repository->getViewDisplay($entity_type_id, $bundle_id, $view_mode_id);

  // Should be successful but actually throws the ConfigEntityDependencyException.
  // It became impossible to programmatically create a new entity display with this exception being thrown.
  return $display->save();
}

Not sure what the best approach is but we should find a way to allow saving of new display and calculating dependencies without throwing exception.

Sounds like two actions are needed:
1. add (a version of) the code in #44 as a test case, coupled with other rational variations if any.

2. update the patch to permit (1) to be run, i.e. creating display programmatically.

For (2) I suggest replacing the new 'throw' with setting a flag on the EntityDIsplayBase object signalling that dependencies are out of date, and then on save() if the flag is set then update the dependencies and _at that time_ throw the exception, as I would expect by then everything to exist.

If this doesn't work I'm somewhat stumped - the exception is thrown when the entity display for this display mode can't be loaded, so in what circumstances is it ok to have a display config referencing an unloadable mode config?

#43 sadly doesn't apply anymore on D10.1.2

Rerolled #43 against 11.x as MR.

@matthieuscarset @rivimey I think we should then proceed there instead of patches.

MR!6920 as patch file against 11.x (based on #43)

Anybody → closed merge request !6922

Anybody → changed the visibility of the branch 2741429-calculate-dependencies-doesnt-check-mode-entity-10.3.x to hidden.

Static patch from MR!6923 for Drupal 10.2.x attached!

Does no more apply on 11.x -.-

anybody → changed the visibility of the branch 11.x to hidden.

Static patch for 11.x attached and MR updated. No changes in diff.

anybody → changed the visibility of the branch 2741429-calculate-dependencies-doesnt-check-mode-entity-10.2.x to hidden.

anybody → changed the visibility of the branch 2741429-calculate-dependencies-doesnt-check-mode-entity to hidden.