The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇬🇧United Kingdom catch
After 🐛 Stampedes and cold cache performance issues with css/js aggregation Fixed (in 10.1.x) AssetDumper::dump() is no longer used in core, except in two deprecated classes which are no longer used.
That means this issue should be 'fixed' apart from the code still being there. I've opened 📌 Deprecate AssetDumper::dump() Active to deprecate the methods.
The new URLs shouldn't have this problem since any hashes are only in query arguments not the main filename, although not closing this out just yet because it would still be feasible to fix this for 10.0.x and 9.5.x, and it might be worth a second opinion on whether the new URLs are adblocker proof.
- Status changed to Active
over 1 year ago 1:22pm 20 August 2023 - 🇬🇧United Kingdom catch
#25 is wrong, the filenames still have hashes in 10.1.x
However I have no idea how we can prevent that string from appearing in the filename - the hash is meaningful.
What about adding the suffix to the filename for some filters? Other ones should probably have bug reports opened against them.