Contrib.social

Allow ServiceModifierInterface to be added to container builder

Open on Drupal.org →
Created on 4 May 2016, about 9 years ago
Updated 21 July 2025, 13 days ago

The Drush and Drupal Console teams are investigating a better way to find contrib module command files using tagged services in a modules services.yml file. Currently, this can be done by creating a subclass of DrupalKernel inside of Drush or DrupalConsole. The Drush PR to do this is here: https://github.com/drush-ops/drush/pull/2169

We are presently planning on moving ahead with this strategy, although there is some fragility in that the technique could break if createFromRequest() changed in some future release. If we had a public function in core that allowed us to add the ServiceModifierInterface to the container builder, then we would have future-proof access to the tagged services. The Drush PR already tests for the existence of the DrupalKernel::addServiceModifier() method. If found, the core DrupalKernel is used; if it is not found, then Drush uses its own subclass of DrupalKernel that provides this function.

✨ Feature request
Status

Postponed: needs info

Version

11.0 🔥

Component

base system

Created by

🇺🇸United States greg.1.anderson

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 13 days ago →
    🇺🇸United States smustgrave

    Thank you for sharing your idea for improving Drupal.

    We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024