LinkGenerator is doing too much and GeneratedLink should not be mutable

Created on 4 May 2016, over 9 years ago
Updated 12 August 2025, 12 days ago

Follow-up to #2693725: Add to allow for non-link links โ†’

Problem/Motivation

The fix in #2693725: Add to allow for non-link links โ†’ exposed the fact that LinkGenerator is doing a lot of pre processing when it comes to GeneratedLink objects. We can do better.

Proposed resolution

Make the GeneratedLink object do the HTML building.

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Postponed: needs info

Version

11.0 ๐Ÿ”ฅ

Component

routing system

Created by

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom alexpott ๐Ÿ‡ช๐Ÿ‡บ๐ŸŒ

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom catch

    This is still relevant, could use the patch converting to an MR.

  • First commit to issue fork.
  • Pipeline finished with Failed
    2 days ago
    #578965
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia libbna New Delhi, India

    Iโ€™ve created an MR for patch #12, but the patch references the file ThemeRenderAndAutoescapeTest.php, which doesnโ€™t exist in the current codebase. Should I create this file?

  • Pipeline finished with Failed
    2 days ago
    #578977
  • The Needs Review Queue Bot โ†’ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide โ†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024