Revisit permissions required to view contact messages

Also tested #62 but I don't see any permission setting I'm afraid. I have run update.php and cleared the cache.

Is there anything else I need to do?

Sorry for letting this sit so long, still applies but will need some updates for tests to work.

contact_storage_entity_type_alter() has a todo to add an access control handler, not sure if it's worth adding one, but we should at least remove that todo.

darren.fisher → made their first commit to this issue’s fork.

As a result of trying to fix some gitlab-ci test failures I've discovered via cspell that there is a misspelling which I'd be reluctant to change:

Cspell turned up:
constact

in contact_storage.module:

$fields['message']->addConstraint('ConstactStorageMaximumSubmissions', []);

in src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraint.php:

class ConstactStorageMaximumSubmissionsConstraint extends Constraint {

in src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraintValidator.php:
class ConstactStorageMaximumSubmissionsConstraintValidator extends ConstraintValidator {

These should surely be ContactStorageMaximumSubmissions, ContactStorageMaximumSubmissionsConstraint, and ContactStorageMaximumSubmissionsConstraintValidator respectively?

I'm pretty sure changing these now could have side effects so I will leave these alone.

Annoyingly I've just spotted there is already a phpcs issue in the queue that likely resolves any phpcs issues I've just cleanup up in here. Apologies. My bad. Should have looked first!

The PHPUnit failure is a bit beyond me and there are still a ton of phpstan issues. Hopefully this helped and didn't muddy the waters!