- Status changed to Needs review
about 2 years ago 1:04pm 20 February 2023 - last update
over 1 year ago 94 pass, 1 fail - 🇯🇴Jordan Rajab Natshah Jordan
Entity Embed 8.x-1.4 was released on: 8 Jun 2023 by: Dave Reid →
Thank you, Dave
https://www.drupal.org/project/entity_embed/releases/8.x-1.4 →Re-rolled the patch from #17 to work with Entity Embed 8.x-1.4
The last submitted patch, 20: 2679875-20.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 68 pass, 5 fail - last update
over 1 year ago Composer require failure - Status changed to Needs work
over 1 year ago 8:52pm 7 November 2023 - 🇯🇴Jordan Rajab Natshah Jordan
Entity Embed 8.x-1.5 on: 6 Nov 2023 by: Dave Reid →
Thanks, Dave
https://www.drupal.org/project/entity_embed/releases/8.x-1.5 →Re-rolled the patch from #20 to work with Entity Embed 8.x-1.5
- 🇯🇴Jordan Rajab Natshah Jordan
Hitting a fatal error with #22
The code now is doing work for CKEditor 4 and Creditor 5 with the same code base. - Assigned to Rajab Natshah
- Status changed to Active
over 1 year ago 7:31am 8 November 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:02am 8 November 2023 - 🇺🇸United States loze Los Angeles
This works fairly well in many cases, however when the IEF has a media browser field in it, when you click the button to open the media browser the entity embed IEF modal is replaced with the media browser, and clicking the insert media button closes the whole modal so nothing is ever added.
Clicking a media browser button (or any for element that opens a modal) should spawn a new modal on top. Im not sure if this is something to address here or with the media module.