TypedConfigManager::_getDefinitionWithReplacements() incorrectly replaces generic definition

Created on 5 February 2016, almost 9 years ago
Updated 8 November 2023, about 1 year ago

Problem/Motivation

The new method added by #2392057: Config schema fails to expand dynamic top-level types β†’ has a small but nasty bug.

Instead of adding a definition for the computed type, it replaces the original definition. That means the second and following elements for the same wildcard/generic type use the definition for the first and fail.

Proposed resolution

Use the correct key to set it.

Part of the problem seems to be the confusing naming between $type and $base_plugin_id. $base_plugin_id isn't "base", it's the real, full, replaced type. We could switch the variables to make the code easier to understand.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

8.4 ⚰️

Component
ConfigurationΒ  β†’

Last updated 7 days ago

Created by

πŸ‡¨πŸ‡­Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
  • Contributed project blocker

    It denotes an issue that prevents porting of a contributed project to the stable version of Drupal due to missing APIs, regressions, and so on.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024