- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Think the issue summary needs an update.
Research why this happens and fix.
What was found and how was it fixed?
- 🇬🇧United Kingdom catch
The approach in the merge request looks OK to me, but none of the previous attempts at test coverage will be relevant with that approach.
- 🇨🇦Canada gapple
@Yogesh Sahu, your patch looks like it's done a PSR-2 reformatting of the entire file, and it's unclear what changes your patch is based on.
- Status changed to Needs review
almost 2 years ago 7:11am 17 February 2023 - 🇨🇦Canada gapple
Rebased the MR, and added tests for the
ChainedFastBackendFactory
class. - Status changed to Needs work
almost 2 years ago 11:59am 17 February 2023 - 🇺🇸United States smustgrave
Seems close to ready just some CI failures in the MR
- Status changed to Needs review
almost 2 years ago 12:55am 18 February 2023 - Status changed to Needs work
almost 2 years ago 5:16pm 18 February 2023 - 🇺🇸United States smustgrave
Removing issue summary update as that looks completed in #59
When I ran the tests locally without the fix
testIdenticalService failed with "Symfony\Component\DependencyInjection\ContainerInterface::get('cache.backend.test', 1): object was not expected to be called more than once." = GOOD
testDifferentServices = Passed.
Shouldn't both tests fail?
If I got that wrong then think this is good to be marked RTBC
- Status changed to RTBC
almost 2 years ago 6:55am 19 February 2023 - 🇨🇦Canada gapple
testDifferentServices()
uses the correct way to instantiate the factory, so should pass both before and after. - Status changed to Fixed
almost 2 years ago 5:37pm 20 February 2023