Allow to opt-in for render caching on POST requests

Created on 21 January 2016, over 8 years ago

Updated 29 January 2024, 5 months ago

Problem/Motivation

There are cases where enabling render caching on POST requests is perfectly safe, even required. For example, token.module would like to use render caching on the token tree but that's almost always opened on POST requests because it's opened in an ajax dialog most of the time.

I'm aware that we'd like to enable it always, but I honestly don't know if we can pull that off for 8.x and there's no progress on that topic at the moment. See 📌 Allow both AJAX and non-AJAX forms to POST to dedicated URLs Postponed

This suggestion is trivial to implement however.

Proposed resolution

Add a post => TRUE flag to #cache, if set, skip the safe methods checks.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Postponed

Version

11.0 🔥

Component

Render →

Last updated about 23 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @moshe weitzman

Created by

🇨🇭Switzerland Berdir Switzerland

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇳India Nikhil_110
Attached patch against drupal 10.1.x
Comment 5 months ago →
🇺🇦Ukraine vasyl.kletsko
Updated to Drupal 10.2.x
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 5 months ago
Patch Failed to Apply
Status changed to Postponed 5 months ago5:06pm 29 January 2024
Comment 5 months ago →
🇬🇧United Kingdom catch
I forgot this issue existed and opened 📌 Make POST requests render cacheable Needs work , it doesn't use an opt-in, instead it special cases forms so that all POST requests are render cached but all forms are excluded. Green MR over there. Postponing this issue on that one - not an exact duplicate since the approach is different, but if one lands we won't need the other.
Comment 5 months ago →
🇺🇦Ukraine vasyl.kletsko

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024