Coder Review Upgrades

Created on 9 January 2016, almost 9 years ago
Updated 30 July 2024, 5 months ago

Pareview.sh Review :

http://pareview.sh/pareview/httpgitdrupalorgprojectfacebookyousharegit

Attached screenshot of issue list :

📌 Task
Status

Needs work

Version

2.0

Component

Code

Created by

🇮🇳India ashishdalvi Mumbai

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work 5 months ago
  • 🇵🇭Philippines cleavinjosh

    Hi @rajeshwari10,

    I applied your patch, it was not applied smoothly and I still encountered some phpcs issues.

    ➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml facebook_you_share
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/facebook_you_share/includes/facebook_you_share.admin.inc
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      82 | WARNING | [ ] All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "facebook_you_share"
         |         |     but found "fb_app_id"
      90 | WARNING | [ ] All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "facebook_you_share"
         |         |     but found "fb_redirect_url"
     108 | WARNING | [ ] All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "facebook_you_share"
         |         |     but found "fb_content_types"
     126 | WARNING | [ ] All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "facebook_you_share"
         |         |     but found "share_location"
     157 | WARNING | [ ] All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "facebook_you_share"
         |         |     but found "fb_share_userpoints_check"
     164 | WARNING | [ ] All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "facebook_you_share"
         |         |     but found "fb_share_userpoints_points"
     262 | WARNING | [x] '@TODO make the image path relative' should match the format '@todo Fix problem X here.'
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/facebook_you_share/includes/facebook_you_share.pages.inc
    -----------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------------------------------
     78 | WARNING | [x] '@TODO: Provide user the ability to alter the message shown to user..' should match the format '@todo Fix problem X here.'
    -----------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -----------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/facebook_you_share/facebook_you_share.install
    ------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------
     26 | ERROR | [x] Expected 1 blank line after function; 0 found
    ------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------
    
    Time: 164ms; Memory: 12MB

    Please check and advise.
    Thank you.

Production build 0.71.5 2024