Create an upgrade path to determine if default_config_hash should be added (2625258)

Created on 3 December 2015, almost 9 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

Follow-up to #2625258: LocaleConfigManager::updateConfigTranslations() deletes translations if a config object's name happens to match that of a shipped configuration object β†’ which adds a hash to configuration files. We need to provide a upgrade path for existing sites.

Proposed resolution

Discussed with @catch and @GΓ‘bor Hojtsy. We agreed that the upgrade path should:

  • check all active config and if name does not match - do not add hash
  • If name matches but has custom config translations - do NOT add hash
  • Otherwise add hash.

This way we don't get data loss and most sites will get localisations for default config.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

Existing configuration entities created through the installer have a default_config_hash key set.

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
ConfigurationΒ  β†’

Last updated 1 day ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024