GD toolkit & operations should catch \Throwable to fail gracefully in case of errors

But then we need a followup to keep trying to find a solution for insufficient memory issues.

Does this still need a followup?

Filed 🐛 GD toolkit & operations should fail gracefully in case of memory issues Needs work for follow-up.

Do you have a recommended way to manually test? Tried lowering my memory and using the snippet in the IS but couldn't trigger.

@smustgrave I think we need to leave memory testing to the followup. The automated tests cover the base case of any throwable being thrown. Apparently the memory issues are not catchable, or at least not under some PHP configurations. See the commit that was reverted, #124, #127.

Can the issue summary be updated please. Since this is not about memory.

Thank you!

Tested this out by editing Drupal\system\Plugin\ImageToolkit\Operation\gd\Convert changing line 59 to

if ($this->getToolkit()->apply('creatfasde_new', $data)) {

Without the patch when I create a media object I get 2 errors in the logs

Image convert failed using the gd toolkit on and

The selected image handling toolkit 'gd' can not process operation 'creatfasde_new'.

Applied the fix

Created another media object

No errors logged.

Mmmm that’s not right then. Missing plugin should be logged and fail the effect - we have regression here.

I repeated the steps in #141, but just saving an image style containing a convert effect through the configuration UI. Both without and with the patch, after clicking 'save' on the image style configuration form I get the two errors logged, which means to me the missing plugin is properly handled.

Committed 4e49b11 and pushed to 10.1.x. Thanks!

mondrake → closed merge request !2860

Automatically closed - issue fixed for 2 weeks with no activity.