- last update
over 1 year ago run-tests.sh fatal error -
podarok β
committed eaaaa4c3 on 2.0.x authored by
Spokje β
Issue #2581223 by Spokje, Dylan Donkersgoed, attisan, DieterHolvoet,...
-
podarok β
committed eaaaa4c3 on 2.0.x authored by
Spokje β
- Status changed to Fixed
over 1 year ago 10:01am 11 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 10:44pm 7 June 2023 - πΊπ¦Ukraine anpolimus Kyiv
Thank you all on pushing this feature forward.
I'm testing it and can see that more or less code works, but fails on the save.
For example, I have menu as reference and want to create new and save it.
On save action I'm getting:
TypeError: Drupal\inline_entity_form\ReferenceUpgrader::upgradeEntityReferences(): Argument #1 ($entity) must be of type Drupal\Core\Entity\FieldableEntityInterface, Drupal\system\Entity\Menu given, called in /var/www/docroot/modules/contrib/inline_entity_form/src/WidgetSubmit.php on line 57 in Drupal\inline_entity_form\ReferenceUpgrader->upgradeEntityReferences() (line 46 of /var/www/docroot/modules/contrib/inline_entity_form/src/ReferenceUpgrader.php)
That is because, code of the reference save was hard-coded to work with content entities.
We have to add config entity support here:
https://git.drupalcode.org/project/inline_entity_form/-/blob/8.x-1.x/src... - π³π±Netherlands Martijn de Wit π³π± The Netherlands
@anpolimus can you create a new issue ticket as follow up ?
- πΊπ¦Ukraine podarok Ukraine
Issue will be created, no worries. I'm also involved in this fix
- πΊπ¦Ukraine anpolimus Kyiv
Link to new issue: https://www.drupal.org/project/inline_entity_form/issues/3365747 π ConfigEntityReference error during creation of the new referenced entity Closed: outdated
- Status changed to Needs work
11 months ago 6:40pm 9 December 2023 - π©πͺGermany geek-merlin Freiburg, Germany
This urgently needs tests before any commit. As the issue tag sais.