Contrib.social

In Views, FieldPluginBase::renderAsLink() should return a render array, not a string

Open on Drupal.org →
Created on 19 September 2015, over 9 years ago
Updated 29 May 2025, 2 days ago

Follow-up to #2568977: Replace SafeMarkup::format() in the link generator - it's a bad example to everyone →

core/modules/views/src/Plugin/views/field/FieldPluginBase.php

In function renderAsLink() it calls the renderer earlier than needed.

Proposed resolution

Return a render array instead of a string.

Remaining tasks

  • make patch
  • Review
  • Commit

User interface changes

None

API changes

none (protected method)

Data model changes

None

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

views.module

Created by

🇺🇸United States pwolanin

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 2 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024