Contrib.social

[Follow-up] PluginBase::viewsTokenReplace uses renderPlain which may limit the use of attached assets

Open on Drupal.org →
Created on 10 September 2015, almost 10 years ago
Updated 28 May 2025, about 2 months ago

Follow up from #2492839: Views replacement token bc layer allows for Twig template injection via arguments → . The use of renderPlain() instead of executeInRenderContext() could limit use of the Views token system in the future. Currently there is no way to attach assets to a token, but perhaps that would make sense someday? Or perhaps render contexts will grow to include things that do make sense in a Views token.

For now, this is a landing page for an @todo in the code.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

views.module

Created by

🇺🇸United States mikeker

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Comment 22 days ago →
    🇩🇪Germany mxh Offenburg

    Stumbled into this, experiencing the exact problem as described in #2.

    I'm wondering why all that stuff is being executed in an isolated way. This doesn't allow to add relevant cacheability metadata, and attaching more assets when needed is also not possible. Yes it's kind of an edge case, but it's possible to call attach_library without any error so either it should be supported in there or an error should be thrown when attempting to do such thing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024