Consider renaming renderer.config

Created on 18 August 2015, almost 10 years ago

Updated 27 May 2025, 4 days ago

Problem/Motivation

From #2551989-7: Move replacing of placeholders from HtmlRenderer to HtmlResponseAttachmentsProcessor → :

I've spent some time on IRC discussing this change on IRC with @Wim Leers I'm that happy that we're injecting and using renderer.config into the HtmlRenderer and using it. We discussed several work around including:

Relying on HtmlResponseAttachmentsProcessor to add them, This does not work because HtmlRenderer needs to return a properly cacheable response with all cache contexts

Adding a new method on the Renderer that does renderRoot without the placeholdering. This seems suboptimal ... it is alreadt hard to work out when to use renderRoot(), renderPlain() and just plain ol' render().

Maybe we should rename renderer.config to something that does not seem so specific.

I think only the last one is actually worth pursuing and we can do that as a followup.

This is that follow-up.

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

None.

API changes

TBD

Data model changes

None.

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

render system

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 4 days ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024