Refactor FormBuilderTest::testChildAccessInheritance

Created on 13 August 2015, almost 10 years ago

Updated 26 May 2025, 8 days ago

While working on #2526326: Update CacheableMetadata & AccessResult to use RefinableCacheableDependency(Interface|Trait) → , @alexpott noticed that some unit tests didn't pass when doing phpunit -c core --testsuite unit.
I spent some time fixing the tests (PermissionAccessCheckTest, FormBuilderTest and MenuLinkTreeTest).

While the tests pass now, the changes done to FormBuilderTest in https://www.drupal.org/node/2526326#comment-10217859 → look like they reduce the test's value or it was doing useless things before.

We need to decide if the removal of the cache contexts from the tests makes an actual difference and if it does, we need to improve the test so it's less fragile.

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

forms system

Created by

🇧🇪Belgium borisson_ Mechelen, 🇧🇪

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 days ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024