Fix shortcut_install() and shortcut_themes_installed(): Only update config when syncing flag is FALSE

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@jibran - system is a special case. It's always installed and the site UUID is even more special with respect to configuration imports.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Looks like this is still valid (install hook in shortcut on 11.x still looks roughly the same), needs a reroll into an MR.

Please review MR from #24.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Tried to reproduce this issue, but couldn't. These are the things that I've tried so far in fresh Drupal 10.3 instance (standard profile)

• Set third_party_settings.shortcut.module_link value in claro.settings to FALSE
• Exported the configuration
• Uninstalled the shortcut module
• Imported the configuration
• The value of third_party_settings.shortcut.module_link should have changed to TRUE as per the hook_install code in the module. But the value after config sync was still FALSE

• Set third_party_settings.shortcut.module_link value in claro.settings to FALSE
• Exported configuraion
• Changed the default admin theme to stark
• Imported the configuration
• The value of third_party_settings.shortcut.module_link should have changed to TRUE as per the hook_install code in the module. But the value after config sync was still FALSE

So adding 'Needs steps to reproduce' tag.

Also, adding !\Drupal::isConfigSyncing() condition in shortcut_themes_installed breaks the standard profile recipe test. \Drupal::isConfigSyncing() is true while applying the standard profile recipe. Sothird_party_settings.shortcut.module_link value in claro.settings is never set to true.