In #2542776: Add an Upsert class → , we added an UPSERT query to the database system which only worked on tables with one unique index / primary key, composed of a single field. This limitation was imposed by the minimum SQLite version supported by Drupal at the time, which lacked proper support for UPSERT queries. In the meantime, SQLite added a real UPSERT in 3.24.
For Drupal 9.x we increased the minimum version of SQLite to 8.26 in #3107155: Discuss lowering SQLite version requirement from 3.26 to 3.22 in Drupal 9 → , and one of the main motivations was the improved UPSERT capability, per #3107155-15: Discuss lowering SQLite version requirement from 3.26 to 3.22 in Drupal 9 → .
Now that all three core database drivers support UPSERT queries on unique/primary key constraints composed of multiple fields, we should take advantage of it and replace core's usage of "Merge" queries where possible.
The benefit is that a Merge query is potentially composed of 3 separate queries (SELECT, INSERT and UPDATE), while UPSERTs can do the same thing (in most situations) in a single query.
Review.
Nope.
API addition, TBD.
Nope.
TBD.
Needs work
11.0 🔥
Particularly affects sites running on the PostgreSQL database.
It affects performance. It is often combined with the Needs profiling tag.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@amateescu: Thank you for your work on this.
Unfortunately it no longer applies to 9.5.x or 10.x. Any chance you have rerolled this patch recently?