Side-quest of
📌
Simplify Element::children() stable sort.
Needs work
There seems to be a problem with the #groups logic for vertical tabs.
It might be specific to the filter admin form, or it could be a more general problem.
In FilterFormatFormBase::form(), if we omit the $form['filters']['settings'][$name]['#weight'], the vertical tabs won't show up on admin/config/content/formats/manage/full_html.
To demonstrate, I attach a patch with failing test.
Looking further into this, using a #post_render callback for debugging, I found that by removing the #weight, the following form array elements become references, instead of regular arrays:
$form['filters']['settings']['filter_html']
$form['filters']['settings']['filter_url']
I suppose what happens now is the element being rendered twice, and the second time $elements['#printed'] is already set, so it skips.
Something like this.
The reason for the reference vs no-reference: If a #weight is set on any one child element, then Element::children() will remove and re-insert all the children, effectively destroying all references.
However, by removing the #weight from all children, Element::children() will silently pass through and do nothing.
Interestingly, other forms with vertical tabs work just fine without weights. One example is the visibility tabs in the BlockForm.
Closed: outdated
11.0 🔥
Last updated
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I tested this on Drupal 11.x, standard install. I commented out the line, https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/filte..., cleared cached and loaded admin/config/content/formats/manage/full_html. The vertical tabs displayed.
Therefor I am closing this issue as outdated.