Contrib.social

[PP-1] Require that AttachmentsInterface implementations have all attachment types present by default

Open on Drupal.org →
Created on 18 June 2015, almost 10 years ago
Updated 30 May 2025, 4 days ago

Problem/Motivation

Per comments 72.7, 73.7, 77, 82 and 93 in #2407195: Move attachment processing to services and per-type response subclasses → , this is what happened, for consistency with other code in D8 HEAD:

@@ -14,28 +14,29 @@
-  protected $attachments = [
-    'library' => [],
-    'drupalSettings' => [],
-    'html_head' => [],
-    'feed' => [],
-    'html_head_link' => [],
-    'http_header' => [],
-  ];
+  protected $attachments = [];

But, Crell feels this removes predictability; he feels it'd be better to have those keys present, so that one can reliably do ->getAttachments()['library'], without the need for an isset().

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

None.

API changes

TBD

Data model changes

TBD

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

render system

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 4 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024