FilterCaption hard-codes allowed tags

// Sanitize caption: decode HTML encoding, limit allowed HTML tags; only // allow inline tags that are allowed by default, plus <br>. $caption = Html::decodeEntities($caption); $caption = Xss::filter($caption, array('a', 'em', 'strong', 'cite', 'code', 'br'));

// Override allowedContent setting for the 'caption' nested editable. // This must match what caption_filter enforces. // @see \Drupal\filter\Plugin\Filter\FilterCaption::process() // @see \Drupal\Component\Utility\Xss::filter() widgetDefinition.editables.caption.allowedContent = 'a[!href]; em strong cite code br';

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment over 1 year ago →
🇺🇸United States AaronBauman Philadelphia
is this still an issue for ckeditor5?
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Patch Failed to Apply
Comment 11 months ago →
🇫🇷France duaelfr Montpellier, France
Yes! I can confirm it is still an issue. See \Drupal\filter\Plugin\Filter\FilterCaption::process().
I cannot find any restriction on the CKEditor side anymore, though.

Backend:

Frontend:
Comment 11 months ago →
🇫🇷France duaelfr Montpellier, France
Updated IS
Comment 8 months ago →
🇺🇸United States pdxclankeith
Any progress on this? My client needs to add to captions to their website, and currently can't. We're CKE5 on Drupal 10.2.7 (going to 10.3.0 very soon). Thanks!
Comment 17 days ago →
🇺🇸United States bwoods
Given that this is still in development, I created a quick-and-dirty patch to just add the superscript and subscript tags to the existing code.

FilterCaption hard-codes allowed tags

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities