[policy, no patch] Are CSS changes change record worthy?

Created on 2 June 2015, about 10 years ago
Updated 12 December 2024, 7 months ago

Problem/Motivation

In #2485375: Clean up shortcut CSS inline with our CSS standards I asked for a change record since this issue changed CSS classes that existing Drupal 8 sites might already rely on.

@alexpott thinks that filing CRs for CSS changes like active to is-active is correct because this class is old as hat and how else are themers expected to be notified? ( https://www.drupal.org/node/2281785 ) Also if markup and CSS is not an API (and therefore requiring CRs) why do we freeze it?

See https://www.drupal.org/list-changes/published/drupal?keywords_descriptio...

Steps to reproduce

Proposed resolution

Remaining tasks

Decide if something needs to be added to https://www.drupal.org/about/core/policies/core-change-policies/change-r...

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

other

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇿New Zealand quietone

    Let's see if we can resolve this.

    I've asked in #core-development and #css for some feedback.

  • 🇳🇿New Zealand quietone

    jacine replied in #frontend giving examples where the change record is needed for CSS changes. And there are change records for CSS changes, so this is happening. The policy is deliberately general to allow flexibility but we could add a phrase to include CSS.

  • 🇺🇸United States smustgrave

    As mentioned in slack.

    If the css change is in claro or olivero I’d be less inclined to say a CR is needed.

    But if the change is on the module level then I think to be safe a CR should be included.

    Extreme example but what if field_item class gets background red added to it. It would be nice to announce such a change

  • 🇺🇸United States smustgrave

    Thoughts?

  • 🇳🇿New Zealand quietone

    I changed the policy the make it clear that CSS changes are to be considered. I did not attempt to define what a significant CSS change would be or to provide examples. I think it is OK to be flexible and allow those working on a issue to decide.

    I am going to close this. The change is only a few words and simple.

    Thanks

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 15 days ago
  • 🇳🇿New Zealand quietone

    Changing to latest version when this was closed.

Production build 0.71.5 2024