- Merge request !160Issue #2476669: EntityListBuilder should render the entity label → (Open) created by murz
- 🇷🇺Russia Chi
I would also add ID column to the default list builder.
Actually it does show entity ID even though the class name is
EntityLabelListBuilder
.I think it needs to be moved to the
EntityListBuilder
. If this is considered as BC break we should introduce the change in 11.x. - 🇬🇧United Kingdom joachim
BC policy says:
> Particular entity handlers should not be considered part of the public API
-- that doesn't apply here, as this is a base class, and not a *particular* entity handler for a particular entity type.
> In general, only interfaces can be relied on as the public API. With the exception of base classes, developers should generally assume that implementations of classes will change
-- this does apply, as it's a base class.
So I agree that making this change in the EntityListBuilder would be a BC break.
However, we could do it in stages:
- now: add the new EntityLabelListBuilder class. That way core and contrib can start using it.
- 11.x: move the new code to EntityListBuilder, deprecate EntityLabelListBuilder
- 12.x: remove EntityLabelListBuilder - 🇷🇺Russia Chi
#53 Makes sense.
I just submitted a patch to Entity API module that addresses the same issue.
https://www.drupal.org/project/entity/issues/2913205#comment-14888086 ✨ Add a list builder extended from entitylistbuilder with atleast the name Needs review
- Status changed to Needs review
4 days ago 9:49am 19 May 2025 - 🇦🇲Armenia murz Yerevan, Armenia
Moving to "Needs review" to get an answer for the MR's comment https://git.drupalcode.org/project/drupal/-/merge_requests/160#note_146560
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.