- π¬π§United Kingdom scott_euser
I know these issues are ancient, but I was trying to browse through the user interface related issues to see if there are any plans in place in general. We started leveraging Search API for the 'AI Search' sub-module of AI and have extended some form classes. Would be interested in contributing to modernising the 'Add fields' wizard/edit approaches to match Drupal Core more (also so things like Gin/Claro/etc all adapt nicely). Is this the best issue still to work from? Or start fresh with new issue and "Closed (outdated)" some of these old ones?
- π§πͺBelgium borisson_ Mechelen, π§πͺ
I think we can still work on this issue, or if we move to another issue we need to credit the people who helped already here. I think it's a safe move to reuse this issue.
- π¦πΉAustria drunken monkey Vienna, Austria
I agreee, please feel free to keep working in these old issues.
- π¬π§United Kingdom scott_euser
Okay I reviewed the options here. I think the Add/Edit fields screen needs more significant thought and rework to bring it more in line with drupal core forms to allow it to more easily feel at home in Claro/Gin so I am suggesting I create a separate issue for that (and work on it) and keep this limited to the original issue summary.
I have crossed out items that are no longer a problem (ie, over the last 7 years must have been fixed elsewhere) and I completed the ones that do exist.
- π¬π§United Kingdom scott_euser
Follow-up created here: β¨ Improve the Search API admin UI for adding/editing fields Active
- π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot, great job!
I just had some minor adjustments, the most relevant being that the
#disabled
setting on the βEnabledβ checkbox makes even less sense now than before, so I removed it.If you are fine with these changes then I can merge. In any case, thanks a lot again!
Reviews from others of course also welcome. - π¬π§United Kingdom scott_euser
Thanks! Just gave your changes a quick run adding a new index again and all looks good. Code perspective, no concerns with the changes. And thanks for the quick review!
- π§πͺBelgium borisson_ Mechelen, π§πͺ
Haven't tested it out locally, but the code changes look great.
- π¦πΉAustria drunken monkey Vienna, Austria
Great to hear, thanks for reviewing!
Merged.
Thanks again! -
drunken monkey β
committed 62a004a2 on 8.x-1.x authored by
scott_euser β
Issue #2471184 by scott_euser, drunken monkey, borisson_: Improved UX of...
-
drunken monkey β
committed 62a004a2 on 8.x-1.x authored by
scott_euser β
- π¬π§United Kingdom scott_euser
Thanks for the quick review & merge!
Re the comment on raising an issue in Core, I raised that here now and added test coverage to demonstrate: π Ajax cannot be triggered from within a table row Active . Should I create a new MR here to update that comment?
- π¬π§United Kingdom scott_euser
Ah whoops, cross posted on that last comment, was meant for β¨ Improve the Search API admin UI for adding/editing fields Active sorry!
Automatically closed - issue fixed for 2 weeks with no activity.