- 🇨🇦Canada dylan donkersgoed London, Ontario
Here's another patch that includes RRULE in the ics file when it's available.
I also noticed when testing this patch that there was a change to the behaviour of the addtocal_field_formatter_view() function that broke some functionality my site had that relied on it. I'm not sure it's actually incorrect though or if it's reasonable to treat this as a public API, so I've fixed it in my code rather than in the patch. Basically, in this check:
if (strtotime($start_date) >= time() || ($display['settings']['past_events'] == TRUE && strtotime($start_date) < time())) {due to changes in how the start date is loaded in earlier logic the start_date is now the very first date instead of the last date. This results in the addtocal link not being rendered in the element for nodes that have a first date before the current date, even if they have an upcoming recurring instance of the date. In my case this was being invoked by a custom block, but I suspect it might happen for the normal field formatter as well. I solved it by updating my field configuration to show the link on past events as well. But I wanted to flag it since it might cause issues for other sites.
- 🇨🇦Canada dylan donkersgoed London, Ontario
Please disregard that last patch, I accidentally removed the URL: line from the ICS file. This one does not have that error. Interdiff is against patch 20 again.