- 🇮🇳India nayana_mvr
Verified the patch #30 and tested it on Drupal version 10.1.x. The patch works fine in 10.1.x also and I have added the before and after screenshots for reference.
Before patch
After patch
- Status changed to RTBC
almost 2 years ago 7:16pm 17 February 2023 - 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
FYI #31 provided screenshots so any following screenshots were duplicative work and not needed.
Testing the code I get the same as everyone else.
Test coverage seems correct and covers the use case.
Looks fine.
- Status changed to Fixed
almost 2 years ago 7:54am 18 February 2023 - 🇺🇸United States smustgrave
Fyi this just caused a random failure in 🐛 Language module shouldn't alter config in sync mode RTBC
- 🇺🇸United States smustgrave
Also relooking at the patch I see t() used in the tests. Should we open a follow up to remove?
- Status changed to Needs work
almost 2 years ago 8:59pm 18 February 2023 - Status changed to Needs review
almost 2 years ago 9:19pm 18 February 2023 - Status changed to RTBC
almost 2 years ago 11:12pm 18 February 2023 - Status changed to Fixed
almost 2 years ago 12:53pm 22 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.