Contrib.social

EntityDisplay::build() requires $item->_attributes to be set.

Open on Drupal.org →
Created on 11 March 2015, over 9 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

#1867518: Leverage entityDisplay to provide fast rendering for fields → added the following piece of code:

        foreach ($field_names as $field_name) {
+          if ($entity->hasField($field_name)) {
+            foreach ($entity->get($field_name) as $item) {
+              $item->_attributes = array();
+            }
+          }
+        } 
 $this->fieldOutput[$entity->id()] = $displays[$bundle]->build($entity, $bundle_fields[$bundle]);

It should better not have to do that.

Proposed resolution

Add _attributes in $display->build directly

Remaining tasks

User interface changes

API changes

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Field  →

Last updated about 16 hours ago

Created by

🇩🇪Germany dawehner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024