The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇦🇺Australia acbramley
Rolled #36 into an MR with 2 omissions:
1. The node.api.php docs changes didn't apply and it was hard to figure out where they were actually meant to go (those docs have since changed quite a bit). I'm happy for someone to put them back
2. The docs changes to checkAllGrants - I may be wrong but it looks like it's checking more than "view all"?I also added back
$access_result->addCacheContexts(['user.node_grants:' . $operation]); - 🇺🇸United States smustgrave
Thanks, seems to have a valid test failure. Am tagging for title update as I've seen general titles before kicked back so trying to avoid that.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
