Contrib.social

Pull reusable routines out of configuration import/export form builders

Open on Drupal.org →
Created on 7 December 2014, almost 10 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

Generally useful code for listing configuration types and for listing configuration entities of a given type are embedded in form generation code in ConfigSingleExportForm::buildForm and ConfigSingleImportForm::buildForm.

Signs that this code should be pulled into helper methods:

Proposed resolution

  • Add two new public methods to ConfigManagerInterface: listConfigTypes and listConfigByType.
  • Implement these two methods in ConfigManager.
  • Convert relevant code in ConfigSingleExportForm::buildForm and ConfigSingleImportForm::buildForm to use these methods.
  • Pull the string used to designate simple system configuration into a constant defined in ConfigManagerInterface. In doing so, change the string from 'system.simple' to 'system_simple' so that it is usable as a configuration key. This way, for example, the key can be used in a settings form for saving a given configuration type. Change all string references from 'system.simple' to ConfigManagerInterface::SYSTEM_SIMPLE_CONFIG.

Remaining tasks

User interface changes

API changes

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Configuration  →

Last updated 2 days ago

Created by

🇨🇦Canada nedjo

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024