Use inverted comma for sql statement generation from annotations in core

Created on 21 October 2014, about 10 years ago

Updated 8 March 2024, 9 months ago

Problem/Motivation

Created an entity with the basetable name "group". Got MySQL error several times. However, my module was fully working. What i noticed is that the error comes from the entity annotation.
It is possible to create a table with MySQL when using prereserved names like group, with, in, select, .. if your SQL statment uses inverted comma. The annotation cannot handle this so the sql statement generator (i have no clue how D8 creates sql statments) should automatically do this.

Example:
Faulty D8 Annotation

/**
 * Defines the select entity
 *
 * @ContentEntityType(
 *   id = "select_entity",
 *   label = @Translation("Selector"),
 *   base_table = "select",
 *   entity_keys = {
 *     "id" = "sid",
 *   },
 * )
 */

SQL generates
CREATE TABLE select (ID int); fails

SQL should generate
CREATE TABLE ´select´ (ID int); works

Proposed resolution

For developer experience all table names should be available so D8 needs to create statements with inverted comma.

Remaining tasks

Check for contra arguments
Implement the new auto generation for statements

✨ Feature request

Status

Closed: duplicate

Version

11.0 🔥

Component

Database →

Last updated about 4 hours ago

Maintained by
🇳🇱Netherlands @daffie

Created by

🇩🇪Germany steamx

Live updates comments and jobs are added and updated live.

DX (Developer Experience)
Enhances developer experience.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 9 months ago →
🇳🇿New Zealand quietone
@steamx, Thank you for the idea!

Comment #5 is correct that are multiple issues of this topic.

The proposal doesn't met the Criteria for evaluating proposed changes → . In this case, there is not demonstrated demand and support for the change.
Status changed to Closed: duplicate 9 months ago11:14am 8 March 2024
Comment 9 months ago →
🇳🇿New Zealand quietone
In Slack, #contribute @Berdir said that this is actually a duplicate of 🐛 Database reserved keywords need to be quoted as per the ANSI standard Fixed , I have added that as related and changed the status here.

Thanks @Berdir

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024