Allow for more flexible form configuration

sabrina.liman → made their first commit to this issue’s fork.

sabrina.liman → closed merge request !6

I've added webforms to the honeypot config page as checkboxes and added a text area that allows form ids to be added.

Setting to "Needs review" to get the testbot to test the patch.

The last submitted patch, 24: allow-more-flexible-form-config-2342473-24.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Those are real test failures caused by the patch. There are also a lot of coding standards problems, mainly because you're using 4 spaces of indentation rather than the Drupal standard 2 spaces.

Can you take a look at the test failures and see if you can resolve them with a new patch?

Had a look at the patch but it might need further work that I don't think I have time for.

Patch from #24 was introducing a new config key additional_form_ids which was not being used anywhere other than the form, and it was merging these values onto the existing form settings. This confused me as adding to additional_form_ids manually had no effect.

I made a few changes to only store in form_settings - but I suspect its actually cleaner to only use additional_form_ids and then update the logic in HoneypotService to be aware of the additional source if ids. This would certainly make the form logic cleaner - but unfortunately was not the first direction I went down.

Leaving as needs work based on above.

Thanks a lot Eric (@ericgsmith) for your comment at #30!

It provided the basic guidelines for the implementation of this feature:

I've created a new merge request MR!28 with the approach suggested with a new configuration form setting additional_form_ids which could be used in the service.

Additionally, a few tests were added to check the additional custom form ids would be properly protected by honeypot, see:
https://git.drupalcode.org/project/honeypot/-/merge_requests/28/diffs#di...

• Job: https://git.drupalcode.org/issue/honeypot-2342473/-/pipelines/190336
• PHPUnit: https://git.drupalcode.org/issue/honeypot-2342473/-/jobs/1769492

 
The added test cases seem to pass.
The only errors currently reported are not related with this merge request, they have already been addressed in different issues, see:

• 📌 PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest' Needs review
• 🐛 [10.2] PHPUnit errors: non-existent service plugin.manager.field.field_type_category Needs review

 
Therefore, at this point, this new feature "should" be ready to be tested, thus switching ticket back to Needs review as an attempt to get more reviews, testing and feedback on MR!28.

Thanks in advance!