Improve Drupal\Core\Updater\Updater: Method signatures, abstract class

Created on 6 August 2014, almost 10 years ago
Updated 31 July 2023, 11 months ago

Follow-up to #2300469: makeBackup() is called without a to parameter in Drupal\Core\Updater\Updater β†’

Problem/Motivation

Drupal\Core\Updater\Updater lacks typehinting and break some code standards:

  • Passing objects by reference (&$object) when is not needed to be explicit
  • Typehinting on arguments

Proposed resolution

  • Make Update abstract.
  • Add abstract method getInstallDirectory().
  • Fix type hinting and docblocks in various methods.

Remaining tasks

Write a patch.

User interface changes

None.

API changes

None.

πŸ“Œ Task
Status

Closed: duplicate

Version

11.0 πŸ”₯

Component
UpdateΒ  β†’

Last updated 7 days ago

  • Maintained by
  • πŸ‡ΊπŸ‡ΈUnited States @tedbow
  • πŸ‡ΊπŸ‡ΈUnited States @dww
Created by

πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024