Performance improvement by adding has_any_children column?

Created on 12 July 2014, almost 11 years ago

Updated 17 April 2025, 25 days ago

Problem/Motivation

In MenuTreeStorage.php

// @todo We want to also check $original['has_children'] here, but that
      //   will be 0 even if there are children if those are hidden.
      //   has_children is really just the rendering hint. So, we either need
      //   to define another column (has_any_children), or do the extra query.

Question is - do we want to increase performance by removing query but add complexity by adding another extra column in the table?

Proposed resolution

Remaining tasks

User interface changes

API changes

Postponed until

#2256521: [META] New plan, Phase 2: Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module →

Original report by @kgoel →

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

menu system

Created by

🇺🇸United States kgoel

Live updates comments and jobs are added and updated live.

Performance
It affects performance. It is often combined with the Needs profiling tag.

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 25 days ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024