[meta] Never replace the container while services are still in call stack.

Created on 8 June 2014, almost 11 years ago

Updated 19 March 2025, 15 days ago

If I understand correctly, it can currently happen that an event causes the container to be rebuilt and replaced in the middle of a request.
Services that originate from the old container may still be in use somewhere, whereas others are replaced.
And then there are the "persisted services"..

Somehow this all seems to work, but it is scary to think about.
I do not claim to perfectly understand all of it, not even close.
But I bet that a lot of things would be easier if the container would not change in the middle of something, but only at specific points in the request where it is "safe".

Speaking in a metaphor:
Don't tear down + rebuild a house from the inside. Do it from the outside.
And if you are still inside and think that you want to rebuild it, take notes instead. Draft a plan of the new house, then leave the old one, and then tear it down and rebuild it following the draft.

In Drupal, this would mean:

Create a container instance, and provide it with a "queue object".
Use the container services to handle the request.
Whenever a component (e.g. a form callback) wants to install a module or change configuration, queue it up for later.
Shut down the container, forget all its services.
Execute the queued operations, outside of any container.
If any of the operations would trigger events that need container services, e.g. hook_install() stuff, create a new container instance to do this.

This would all go nicely together with #2272129: [meta] Introduce a low-level DIC to organize low-level services → , but it may also work standalone.

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

base system

Created by

🇩🇪Germany donquixote

Live updates comments and jobs are added and updated live.

WSCCI

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 15 days ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024