Some things should be typehinted with ConfigurableLanguageManagerInterface not LanguageManagerInterface

Created on 21 May 2014, over 10 years ago
Updated 12 October 2024, about 1 month ago

Problem/Motivation

Noticed in #2212427-21: Use interface instead of class name for language manager where appropriate. β†’ :
Some things should be typehinted with ConfigurableLanguageManagerInterface not LanguageManagerInterface because they depend on functionality in the ConfigurableLanguageManager that comes with the language module.

Proposed resolution

typehint with ConfigurableLanguageManagerInterface (not LanguageManagerInterface) in ... ?

Remaining tasks

<!-- Delete or add (novice) from the tasks below as appropriate. uncomment tasks as the issue advances. add (done) to indicate when they are done, and maybe reference the comment number were they were done. -->
  • Identify which should be ConfigurableLanguageManagerInterface not LanguageManagerInterface
  • git instructions for creating patch | Contributor task documentation for creating a patch
  • <!-- <li><a href=https://drupal.org/contributor-tasks/reroll">perform patch reroll</a></li> --><!-- <li>Review patch to check it fixes the issue, the change is properly documented and for <a href="https://drupal.org/coding-standards" title="Coding standards">coding standards</a>. Make sure patch stays within scope of just this issue. | <a href="https://drupal.org/contributor-tasks/review">Contributor task documentation for reviewing patch</a></li> --><!-- <li>Update issue summary | <a href="https://drupal.org/contributor-tasks/write-issue-summary">Contributor task documentation for updating issue summary</a></li> --><!-- <li>Add automated tests | <a href="https://drupal.org/contributor-tasks/write-tests">Contributor task document for writing automated tests</a> -->

User interface changes

No.

API changes

Yes.

πŸ“Œ Task
Status

Closed: works as designed

Version

11.0 πŸ”₯

Component

language system

Created by

πŸ‡ΊπŸ‡ΈUnited States yesct

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

  • API change

    Changes an existing API or subsystem. Not backportable to earlier major versions, unless absolutely required to fix a critical bug.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    The comment in #2 has answered this such that I think this is working correctly.

    I trust that someone will re-open this if that is incorrect.

Production build 0.71.5 2024