Contrib.social

The locale string storage needs to be rewritten

Open on Drupal.org →
Created on 12 April 2014, about 11 years ago
Updated 14 March 2025, about 2 months ago

Problem/Motivation

The locale string storage interface / implementation is using undocumented arrays as arguments. Also, the database independent code needs to be in a base class.

Proposed resolution

Rewrite with clear, simple methods. For example:

public function findString(array $conditions);

should be split into at least:

public function findString($source, $language, $context = '');
public function findStringByType($source, $type);

and so on.

Tests pass in $lid to this; that shouldn't be possible IMO. If we want we can have a separate method for that -- but even so, 'lid' is a weird thing we shouldnt be using because there's a lid for the string and a string for the location and so it's very confusing. It's an internal id imnsho.

Remaining tasks

Agree, code.

User interface changes

None.

API changes

The StringStorageInterface and StringDatabaseStorage classes gets rewritten. The latter is split into a base class and a storage class. Also I feel the class name is not in line with the rest of core but that's minimal.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

locale.module

Created by

🇨🇦Canada chx

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024