_tracker_remove does not properly update tracker_user and has a redundant db_update for tracker_node

Created on 1 February 2014, over 10 years ago
Updated 22 April 2024, 2 months ago
      // And then we push the out the new changed timestamp to our denormalized
      // tables.
      db_update('tracker_node')
        ->fields(array(
          'changed' => $changed,
          'published' => $node->status,
        ))
        ->condition('nid', $nid)
        ->execute();
      db_update('tracker_node')
        ->fields(array(
          'changed' => $changed,
          'published' => $node->status,
        ))
        ->condition('nid', $nid)
        ->execute();
    }
  }

There appears to be a redundant db_update in _tracker_remove. The second one supposed to apply to tracker_user if the module follows the same structure at the D6 verison. If this is not the case the second db_update probably should be eliminated as unnecessary. This should also be backported to D7.

I have no way of testing this on D8 (not yet familliar enough with D8).

πŸ› Bug report
Status

Needs work

Version

1.0

Component
TrackerΒ  β†’

Last updated 26 days ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States letapjar

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024