Split ImageEffectFormBase into ImageEffectAddForm and ImageEffectEditForm

Created on 16 October 2013, over 11 years ago

Updated 31 March 2025, 2 days ago

Updated: Comment #0

Problem/Motivation

Image effects have a base form that is extended by an add form and an edit form, but the forms do not implement BaseFormIdInterface. Therefore it is currently impossible to alter the 'add' or 'edit' forms specifically, you can only alter both at the same time.

Btw, this issue was generally larger scoped, but it turned that image effects are the only forms in core that are currently not using BaseFormIdInterface when they should. I had found that by chance and had assumed that there would be more, but there isn't. :-)

Proposed resolution

Make ImageEffectFormBase implement BaseFormIdInterface.

Remaining tasks

User interface changes

API changes

Related Issues

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

image.module

Created by

🇩🇪Germany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 2 days ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024